Add the ability to get the total number of pages #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Damn dude, nice to see you start this up. You know what's the licensing restrictions on all the open PRs on the main QuestPDF library? Would be great to pull some of that in here, that guy seems to have been completely ignoring any issues / community code for over a year now. |
Author
|
I searched for it. For open PRS, the license at the time of the commit counts. Therefore, it would be permissible to cherry-pick all open PRS that don't have a commit after the license change. Are you missing something specific? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: QuestPDF#378
Now by calling
document.GeneratePdf, it is possible to get the total number of pages that were generated.byte[] pdf = document.GeneratePdf(out int pageNumbers)Original pr: QuestPDF#871