Fixed designators and clarified footprint of LED.#6
Open
glx-seven wants to merge 1 commit intoFrameworkComputer:mainfrom
Open
Fixed designators and clarified footprint of LED.#6glx-seven wants to merge 1 commit intoFrameworkComputer:mainfrom
glx-seven wants to merge 1 commit intoFrameworkComputer:mainfrom
Conversation
I did change the C2 and R4 designators since they were mixed up. I also did modify the footprint of D2 to make it more obvious how to orient it since usually pin 1 is marked on the physical package but for that LED it's pin 3. Also updated the files to KiCad 7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did change the C2 and R4 designators since they were mixed up. I also did modify the footprint of D2 to make it more obvious how to orient it since usually pin 1 is marked on the physical package but for that LED it's pin 3. Also updated the files to KiCad 7.