windows: Run --versions command if double-clicked#132
Merged
JohnAZoidberg merged 4 commits intomainfrom May 7, 2025
Merged
Conversation
Member
JohnAZoidberg
commented
May 6, 2025
JohnAZoidberg
commented
Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
double-click
branch
from
cc81a91 to
d111ee5
Compare
Member
Author
|
Would also be nice either to elevate permissions if not run as admin or to at least provide a nice error message. |
Only in release builds, because running `cargo run` from non-admin terminal won't work with the resources. Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
double-click
branch
from
974f680 to
7336362
Compare
Member
Author
Done |
Member
Author
|
Found a bug, if I run a release build from the commandline, it'll always open a window and run |
Should always try to run as admin in release builds.
But only autorun --versions if no arguments provided.
Tested:
- [x] Release Build with args
- [x] Run from powershell
- [x] Run from powershell with sudo "In new window"
- [x] Run from powershell with sudo "With input disabled"
- [x] Doubleclick from Explorer
- This is impossible
- [x] Release Build without args
- [x] Run from powershell
- This case autoruns --versions when it shouldn't
- [x] Run from powershell with sudo "In new window"
- This case autoruns --versions when it shouldn't
- [x] Run from powershell with sudo "With input disabled"
- [x] Doubleclick from Explorer
- [x] Debug Build with args
- [x] Run from powershell
- [x] Run from powershell with sudo "In new window"
- [x] Run from powershell with sudo "With input disabled"
- [x] Doubleclick from Explorer
- This is impossible
- [x] Debug Build without args
- [x] Run from powershell
- [x] Run from powershell with sudo "In new window"
- This case autoruns --versions when it shouldn't
- [x] Run from powershell with sudo "With input disabled"
- [x] Doubleclick from Explorer
Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.