esrt: fix ESRT GUID for EFI device#156
Merged
JohnAZoidberg merged 1 commit intoFrameworkComputer:mainfrom May 25, 2025
Merged
Conversation
The EFI GUID in FreeBSD is layouted as following
typedef struct efi_guid {
uint32_t Data1;
uint16_t Data2;
uint16_t Data3;
uint8_t Data4[8];
} efi_guid_t;
Which means the Data1, Data2, Data3 should follows the little endian
rule as the MSB should be in the right side.
Also, the table_len in the ioctl argument of EFI_GET_TABLE should be
follow the uuid structure. Fix it by reorder it.
Sponsored By: FreeBSD Foundation
Sponsored By: Framework Laptop Inc.
JohnAZoidberg
approved these changes
May 25, 2025
Member
JohnAZoidberg
left a comment
JohnAZoidberg
left a comment
There was a problem hiding this comment.
Oops thanks, I could've sworn I tried it.
But maybe I ignored an error because the freebsd syscall is flaky anyway.
Contributor
Author
|
Oops, I think my emacs setup break the linter. Could you please help me fix that? Or I can create a patch for it. |
Member
oh no problem: #158 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EFI GUID in FreeBSD is layouted as following
typedef struct efi_guid {
uint32_t Data1;
uint16_t Data2;
uint16_t Data3;
uint8_t Data4[8];
} efi_guid_t;
Which means the Data1, Data2, Data3 should follows the little endian rule as the MSB should be in the right side.
Also, the table_len in the ioctl argument of EFI_GET_TABLE should be follow the uuid structure. Fix it by reorder it.