You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In general this is not a bad idea. But I wonder how you noticed it.
The commands don't really return machine readable output. We're you trying to separate stdout and stdin on purpose?
The commands don't really return machine readable output. We're you trying to separate stdout and stdin on purpose?
You might be referring to stdout and stderr. They should be separated as convention. For example, if you want to save the device information you can just redirect the stdout output to a file, while keeping the errors in the console. Sending what gone wrong to the file while only printing there was an error in the console doesn't make much sense.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context.
framework_tooluses bothstdoutandstderr. But the former one is being overused, having most of the error messages which should be sent tostderr.This PR only changed print statements which should go to
stderr.