add commands to read/write gpu serial#98
Merged
JohnAZoidberg merged 1 commit intomainfrom Apr 14, 2025
Merged
Conversation
| /// Get gpu bay serial | ||
| GetGpuSerial = 0x3E1D, | ||
| /// Set gpu bay serial and program structure | ||
| SetGpuSerial = 0x3E1F, |
Member
There was a problem hiding this comment.
oh in EC source code this is called EC_CMD_PROGRAM_GPU_EEPROM
Member
|
I renamed it from |
Member
Author
|
yes please enable hex values for magic number as well :) |
Member
Author
|
LGTM, but i authored, so cannot approve. |
TEST=Tested on platform to overwrite the serial And I can see the serial updates to the new value after rebooting the EC. Signed-off-by: Kieran Levin <ktl@frame.work> Co-Authored-By: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
fw16.dgpu_config
branch
from
d57e857 to
87f2132
Compare
Member
Done. Can now use any of |
JohnAZoidberg
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TEST=Tested on platform to overwrite the serial
And I can see the serial updates to the new value after rebooting the EC.