Open
Conversation
Member
JohnAZoidberg
left a comment
There was a problem hiding this comment.
I have some suggestions:
- Let's build the package on GH Actions and not put it in the repo
- Move all release scripts into a subfolder, maybe
release/ - Add trailing newlines to the end of files (I don't get why vscode doesn't do that)
d333a86 to
93e7aae
Compare
Contributor
Author
|
@JohnAZoidberg all good suggestions! I've implemented them all. Put the new |
9a55c4f to
247bc18
Compare
93e7aae to
5535376
Compare
Contributor
Author
|
@JohnAZoidberg same question here! (Although this is currently just merging into my other branch :)) |
Base automatically changed from
better-port-permission-setup-and-errors
to
main
August 25, 2023 09:03
20b25e8 to
2b678b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #47 .
This adds a very simple packaging process and
systemdservice file for theinputmodule-rsto run. I have it running theledmatrixby default now but the idea is to quickly iterate on this to a more general service to take commands viadbusor similar as we've discussed!For now, it generally works. To cut a release, run
./release.sh. It'll installfpm(https://github.com/jordansissel/fpm) if you're missing it and use it to package up the binary that cargo builds into a.deb.Once you install the package with
dpkg -i <package-name>.deb, it'll run a postinstall script to install theudevrule and it will automatically add thesystemdservice and start it. It should persist between reboots.Some other things to consider:
release.shas part of the build, eventually convert it to aMakefile, or eventually use something likebazelto run the build and packaging process if we want to get really fancy.debs, but I included one to easily try installing it withdpkg.rpmfor RHEL-based distros eventually