Conversation
Signed-off-by: Daniel Schaefer <dhs@frame.work>
The stm32 hal hasn't been updated to embedded-hal 1.0. Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
There was a problem hiding this comment.
Pull request overview
This PR updates the project to use embedded-hal version 1.0, which involves significant API changes including the removal of blocking traits and updated module paths for delay and I2C functionality.
Changes:
- Updated embedded-hal dependency from 0.2.7 to 1.0 across all crates
- Migrated from blocking::delay::DelayMs to delay::DelayNs trait
- Migrated from blocking::i2c::{Read, Write} to i2c::I2c trait with associated Error type
- Updated example code to use new rp2040-hal APIs compatible with embedded-hal 1.0
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib.rs | Updated HAL imports and trait bounds to use embedded-hal 1.0 APIs |
| src/devices.rs | Updated trait bounds and error types for device implementations |
| examples/ledmatrix/examples/ledtest.rs | Migrated to new rp2040-hal APIs and removed BSP dependency |
| examples/ledmatrix/Cargo.toml | Updated dependencies to embedded-hal 1.0 and rp2040-hal 0.11.0 |
| examples/adafruit_rgb/examples/stm32.rs | Removed STM32-specific example |
| examples/adafruit_rgb/examples/rgbmatrix.rs | Added new RP2040-based example for RGB matrix |
| examples/adafruit_rgb/examples/gaypride.rs | Migrated from STM32 to RP2040 platform |
| examples/adafruit_rgb/Cargo.toml | Updated package name and dependencies for RP2040 platform |
| Cargo.toml | Updated embedded-hal dependency to 1.0 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| sleep_present = true; | ||
| } | ||
| let sleep = sleep.into_pull_down_input(); | ||
| let mut sleep = sleep.into_pull_down_input(); |
There was a problem hiding this comment.
The variable 'sleep' is shadowed at line 102. Consider using a different name like 'sleep_pull_down' to avoid confusion and improve clarity.
There was a problem hiding this comment.
Hm yeah, good idea, but unrelated to the changes here.
JohnAZoidberg
force-pushed
the
embedded-hal-v1.0
branch
from
e301159 to
6b4fe3b
Compare
Signed-off-by: Daniel Schaefer <dhs@frame.work>
|
Tested on Framework Laptop 16 LED Matrix. Still works, lights up every LED one after the other. |
1 participant
No description provided.