Add example for Framework Laptop 16 Keyboards#8
Merged
JohnAZoidberg merged 1 commit intomainfrom Jan 17, 2026
Merged
Conversation
JohnAZoidberg
force-pushed
the
framework-laptop16-keyboard-example
branch
from
0c049a5 to
e0786fd
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a new example demonstrating LED control on Framework Laptop 16 keyboards and macropads using the IS31FL3743A LED controller. The example cycles through red, green, blue, white, and off states to show all colors blinking.
Changes:
- Added Framework 16 keyboard/macropad example with support for both hardware variants
- Updated main README to include the new example
- Extended CI workflows to build and lint the new example
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| examples/framework16-keyboard/src/main.rs | Main example code implementing LED color cycling for keyboard and macropad variants |
| examples/framework16-keyboard/memory.x | Memory layout configuration for RP2040 bootloader and flash |
| examples/framework16-keyboard/build.rs | Build script to handle memory.x linker configuration |
| examples/framework16-keyboard/README.md | Documentation for building and flashing the example |
| examples/framework16-keyboard/Cargo.toml | Package configuration with feature flags for keyboard/macropad variants |
| examples/framework16-keyboard/.cargo/config.toml | Cargo configuration for target and runner setup |
| README.md | Updated main README to reference the new example |
| .github/workflows/lint.yml | Added CI linting steps for the new example |
| .github/workflows/build.yml | Added CI build steps for the new example |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| 1. Put the keyboard/macropad into bootloader mode | ||
| a. On keyboard hold both alt keys down while powering it on | ||
| a. On macropad hold both keys 1 and 6 (see numpad) down while powering it on |
There was a problem hiding this comment.
List item numbering is inconsistent. Both sub-items use 'a.' when they should use different letters ('a.' and 'b.') or maintain consistent formatting.
Suggested change
| a. On macropad hold both keys 1 and 6 (see numpad) down while powering it on | |
| b. On macropad hold both keys 1 and 6 (see numpad) down while powering it on |
Blink all the colors Signed-off-by: Daniel Schaefer <dhs@frame.work>
JohnAZoidberg
force-pushed
the
framework-laptop16-keyboard-example
branch
from
e0786fd to
f0aba0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blink all the colors.
I tried it on both the keyboard and the macropad.