Closed
Conversation
It manages the chip select by itself, easier to use. Signed-off-by: Daniel Schaefer <dhs@frame.work>
There was a problem hiding this comment.
Pull request overview
This PR updates the ST7306 driver to use SpiBus instead of SpiDevice from the embedded-hal crate, allowing the driver to manage chip select internally for easier usage.
Changes:
- Updated the SPI trait bound from
SpiDevicetoSpiBusacross all generic implementations
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| SPI: SpiDevice, | ||
| SPI: SpiBus, | ||
| DC: OutputPin, | ||
| CS: OutputPin, |
There was a problem hiding this comment.
The CS (chip select) pin is still required as a generic parameter and trait bound, but SpiBus manages chip select internally. Consider removing the CS generic parameter and OutputPin trait bound for CS, as they are no longer needed with SpiBus.
Suggested change
| CS: OutputPin, |
Member
Author
|
Looking at the docs again: https://rtic.rs/dev/api/embedded_hal/spi/index.html#for-driver-authors |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the caller manage chip select.