Skip to content

add --impure option #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liemlb wants to merge 2 commits into
base: main
Choose a base branch
from
Open

add --impure option #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab4f88f
add --impure option
Jan 2, 2026
f688771
add extraFlags setting
Jan 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"name": "shells",
"displayName": "Shells - Nix Flake Environment Switcher",
"description": "Switch development environment to Nix flake-based environment",
"version": "0.0.5",
"version": "0.0.6",
"icon": "icon.png",
"engines": {
"vscode": "^1.85.0"
Expand Down Expand Up @@ -45,6 +45,16 @@
"type": "string",
"default": "",
"description": "Path to the flake.nix file (relative to workspace root). Leave empty to auto-detect."
},
"shells.impure": {
"type": "boolean",
"default": false,
"description": "Allow impure flake evaluation (nix develop --impure)."
},
"shells.nixCommandExtraFlags": {
"type": "array",
"default": [],
"description": "Additional flags can be added via this option (e.g. ['--impure', '--fallback', '--refresh'])."
}
}
}
Expand Down
13 changes: 11 additions & 2 deletions src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,22 @@ async function isNixAvailable(): Promise<boolean> {
* Securely extracts environment variables from nix develop
*/
function getFlakeEnvironment(flakeDir: string): Promise<NodeJS.ProcessEnv> {
const config = vscode.workspace.getConfiguration("shells");
const impure = config.get<boolean>("impure");
const nixCommandExtraFlags = (impure ? ["--impure"] : []).concat(
config.get<string[]>("nixCommandExtraFlags", [])
);
const args = ["develop", flakeDir]
.concat(nixCommandExtraFlags)
.concat(["--command", "env"]);

return new Promise((resolve, reject) => {
const env: NodeJS.ProcessEnv = {};

outputChannel.appendLine(`[${new Date().toISOString()}] Running: nix develop ${flakeDir} --command env`);
outputChannel.appendLine(`[${new Date().toISOString()}] Running: nix ${args.join(" ")}`);
outputChannel.appendLine('='.repeat(80));

const proc = spawn('nix', ['develop', flakeDir, '--command', 'env'], {
const proc = spawn('nix', args, {
cwd: flakeDir,
timeout: 60000, // 60 second timeout
});
Expand Down