Non-zero exit code on status if dory isn't totally "up" #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alias ps=>status for docker-like behavior hidden in here as well. I welcome feedback on the error code pattern. I wanted to make it a "means the number of services down" but figured it didn't actually matter as long as it was easier to script against, for my purposes.
Author
|
Ah, specs! I'll go poke at those and testing the exit codes, also track if there's some value in delaying the exit as well. |
Owner
|
Nice, thanks man! I like it. I can take a look at the spec in more detail tomorrow. I just glanced at it and it seems like the spec may just need to be updated for the new exit status, tho I'm not 100% sure on that yet. |
Owner
|
Yo @ryanmt , you still want to merge this? I totally spaced it and randomly remembered. I looked at the test failure and it's not a big deal. I can refactor it to accommodate the new exit status. Sorry it took freaking forever. Is this still useful? |
Collaborator
|
I think this could be useful, @FreedomBen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alias ps=>status for docker-like behavior hidden in here as well.
I welcome feedback on the error code pattern. I wanted to make it a
"means the number of services down" but figured it didn't actually
matter as long as it was easier to script against, for my purposes.