bugfix/web_encoding: fix web specific encoding issue#348
Open
Mooyeee wants to merge 1 commit intoFrezyx:masterfrom
Open
bugfix/web_encoding: fix web specific encoding issue#348Mooyeee wants to merge 1 commit intoFrezyx:masterfrom
Mooyeee wants to merge 1 commit intoFrezyx:masterfrom
Conversation
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
===========================================
+ Coverage 98.45% 100.00% +1.54%
===========================================
Files 28 8 -20
Lines 583 66 -517
===========================================
- Hits 574 66 -508
+ Misses 9 0 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR solves an encoding issue encountered on web where some special accented characters (i.e. èéàùìò) would translate to
\uFFFD(�) which would make the app crash when trying to log it to the web console.