fix: add missing error and exception details to console logs#398
Open
Zekfad wants to merge 2 commits intoFrezyx:masterfrom
Open
fix: add missing error and exception details to console logs#398Zekfad wants to merge 2 commits intoFrezyx:masterfrom
Zekfad wants to merge 2 commits intoFrezyx:masterfrom
Conversation
Contributor
Reviewer's GuideUpdate generateTextMessage implementations in TalkerData and TalkerLog to include missing error and exception details and replace raw message usage with displayMessage, ensuring full context is logged. Class diagram for updated TalkerData and TalkerLog message generationclassDiagram
class TalkerData {
+String displayTitleWithTime(TimeFormat timeFormat)
+String displayMessage
+String displayException
+String displayError
+String displayStackTrace
+String generateTextMessage(TimeFormat timeFormat)
}
class TalkerLog {
+String generateTextMessage(TimeFormat timeFormat)
}
TalkerLog --|> TalkerData
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Frezyx
approved these changes
Jul 20, 2025
Owner
|
Hello @Zekfad ! |
7298c58 to
d9ac9e0
Compare
d9ac9e0 to
1173b2b
Compare
Author
|
Updated related tests and rebased to recent master. |
Author
|
@Frezyx, sorry to bother; could you please review this PR once more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bugfix for missing error and exception details
Describe the bug
TalkerData#generateTextMessageis missingdisplayExceptionanddisplayError, usesmessageinstead ofdisplayMessagewhich could cause "null" string in logs (intended?).TalkerLog#generateTextMessageis missingdisplayErrorwhich prevents printing errors to console log.To Reproduce
Expected behavior
Summary by Sourcery
Ensure that error and exception details, along with the proper displayMessage, are included in console log output generated by TalkerData and TalkerLog
Bug Fixes: