perf: use initializer instead of late initialization and polymorph getters#399
Open
Zekfad wants to merge 1 commit intoFrezyx:masterfrom
Open
perf: use initializer instead of late initialization and polymorph getters#399Zekfad wants to merge 1 commit intoFrezyx:masterfrom
Zekfad wants to merge 1 commit intoFrezyx:masterfrom
Conversation
Contributor
Reviewer's GuideReplaces late-backed fields and overridden getters with constructor initializer lists and final fields to reduce indirection and improve performance. Class diagram for updated TalkerData, TalkerException, and TalkerErrorclassDiagram
class TalkerData {
<<abstract>>
String? message
LogLevel? logLevel
Exception? exception
Error? error
StackTrace? stackTrace
String? title
DateTime time
AnsiPen? pen
String? key
}
class TalkerException {
Exception exception
String? message
String? key
String? title
LogLevel? logLevel
--
+generateTextMessage()
}
class TalkerError {
Error error
String? message
String? key
String? title
LogLevel? logLevel
--
+generateTextMessage()
}
TalkerException --|> TalkerData
TalkerError --|> TalkerData
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
a71e227 to
9f161f3
Compare
…tters this will remove late initialization checks from runtime and unnecessary getter overloads, which will also make classes more friendly to extension
9f161f3 to
0b4516e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Use constructor initializers and final fields to remove late initialization and polymorphic getters for improved performance.
Enhancements: