Fix pen color ignored in logCustom when key is set#450
Draft
Fix pen color ignored in logCustom when key is set#450
Conversation
Co-authored-by: Frezyx <40857927+Frezyx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix pen color functionality in logCustom method
Fix pen color ignored in logCustom when key is set
Dec 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks a lot for contributing!
When
logCustomis called with aTalkerLogthat has both a custompenand akey(e.g.,TalkerKey.debug), the custom pen color is ignored and replaced with the key's default color.Root cause:
_handleLogDataunconditionally overwritesdata.penviasettings.getPenByKey(key, fallbackPen: data.pen). Sincedebugexists in the default colors map, the fallback is never used.Fix: Only apply the key's default color when no custom pen was provided:
Added test cases verifying:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.