Fix TalkerScreen empty logs and incorrect colors for custom logs#454
Draft
Fix TalkerScreen empty logs and incorrect colors for custom logs#454
Conversation
- Modified data_card.dart to use generateTextMessage() for custom logs - Created ansi_color_converter.dart utility to convert AnsiPen to Flutter Colors - Enhanced talker_data.dart extension to try converting pen field when key not in theme Co-authored-by: Frezyx <40857927+Frezyx@users.noreply.github.com>
- Created custom_logs_example.dart with examples of custom logs - Updated main.dart to use the example logs - Demonstrates both generateTextMessage() override and pen color conversion Co-authored-by: Frezyx <40857927+Frezyx@users.noreply.github.com>
- Created TALKER_SCREEN_FIXES.md with detailed explanation - Updated CHANGELOG.md with fix descriptions - Documented migration guide and examples Co-authored-by: Frezyx <40857927+Frezyx@users.noreply.github.com>
- Improved custom log detection heuristic to be more robust - Made color definitions consistent using Color(0xFFxxx) format - Added caching to AnsiColorConverter to improve performance Co-authored-by: Frezyx <40857927+Frezyx@users.noreply.github.com>
- Added named constants for magic numbers - Extracted color mappings to static const maps - Improved code maintainability and readability Co-authored-by: Frezyx <40857927+Frezyx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix incorrect colors and empty logs in TalkerScreen
Fix TalkerScreen empty logs and incorrect colors for custom logs
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks a lot for contributing!
TalkerScreen displayed empty entries and grey colors for custom logs that override
generateTextMessage()andpenproperties. Console output worked correctly, but the Flutter UI ignored custom implementations.Changes
Core Fixes:
_messagegetter to detect customgenerateTextMessage()overrides via heuristics (newlines or significant length deltas)pencolor conversion as fallback ingetFlutterColor()lookup chain: key → logLevel → pen → greyNew Utility:
Example:
Previously required duplicate color configuration in
TalkerSettings.colorsandTalkerScreenTheme.logColors. Now pen colors are automatically converted when key not found in theme.Documentation:
docs/TALKER_SCREEN_FIXES.mdwith migration guideCHANGELOG.mdexample/lib/custom_logs_example.dartAll changes backward compatible.
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://storage.googleapis.com/flutter_infra_release/flutter/a5cb96369ef86c7e85abf5d662a1ca5d89775053/dart-sdk-linux-x64.zip/usr/bin/curl curl --retry 3 --continue-at - --location --output /tmp/flutter/bin/cache/dart-sdk-linux-x64.zip REDACTED packages/talker_-l ndor/bin/grep grep -l xterm\|rgb est.dart grep class.*extends Tbash(http block)/usr/bin/curl curl --retry 3 --continue-at - --location --output /home/REDACTED/flutter/bin/cache/dart-sdk-linux-x64.zip REDACTED d_guarded_native-f grep grep -l xterm\|rgb .dart /usr/bin/grep rs s/bloc/bloc.dart--nonblock rgo/bin/grep grep(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.