-
Notifications
You must be signed in to change notification settings - Fork 16
Update to Twitch's video embed. #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
| $('.intro-text').addClass('hidden'); | ||
| }); | ||
|
|
||
| player.addEventListener(Twitch.Player.OFFLINE, function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Twitch' is not defined.
| } | ||
| var player = new Twitch.Player("video-player", options); | ||
|
|
||
| player.addEventListener(Twitch.Player.ONLINE, function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Twitch' is not defined.
| var options = { | ||
| channel: twitchUsername | ||
| } | ||
| var player = new Twitch.Player("video-player", options); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'Twitch' is not defined.
js/main.js
Outdated
|
|
||
| player.addEventListener(Twitch.Player.OFFLINE, function() { | ||
| $('#video-player').addClass("hidden"); | ||
| $('.intro-text').removeClass('hidden'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
js/main.js
Outdated
| }); | ||
|
|
||
| player.addEventListener(Twitch.Player.OFFLINE, function() { | ||
| $('#video-player').addClass("hidden"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
js/main.js
Outdated
|
|
||
| player.addEventListener(Twitch.Player.ONLINE, function() { | ||
| $('#video-player').removeClass("hidden"); | ||
| $('.intro-text').addClass('hidden'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
js/main.js
Outdated
| var player = new Twitch.Player("video-player", options); | ||
|
|
||
| player.addEventListener(Twitch.Player.ONLINE, function() { | ||
| $('#video-player').removeClass("hidden"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
js/main.js
Outdated
|
|
||
| var options = { | ||
| channel: twitchUsername | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing semicolon.
js/main.js
Outdated
|
|
||
| player.addEventListener(Twitch.Player.OFFLINE, function() { | ||
| $('#video-player').addClass('hidden'); | ||
| $('.intro-text').removeClass('hidden'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
js/main.js
Outdated
| }); | ||
|
|
||
| player.addEventListener(Twitch.Player.OFFLINE, function() { | ||
| $('#video-player').addClass('hidden'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
js/main.js
Outdated
|
|
||
| player.addEventListener(Twitch.Player.ONLINE, function() { | ||
| $('#video-player').removeClass('hidden'); | ||
| $('.intro-text').addClass('hidden'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
js/main.js
Outdated
| var player = new Twitch.Player("video-player", options); | ||
|
|
||
| player.addEventListener(Twitch.Player.ONLINE, function() { | ||
| $('#video-player').removeClass('hidden'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mixed double and single quotes.
|
|
||
| $.getJSON( "https://api.twitch.tv/kraken/channels/twitchusername/follows?client_id="+ clientId + "&callback=?", function(response) { | ||
| $('.followers span').text(response["_total"]); | ||
| $(".followers span").text(response["_total"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
['_total'] is better written in dot notation.
|
Hey thanks for doing this! I'll take a look soon and we get get this merged in |
#5