Skip to content

Conversation

@alfg
Copy link

@alfg alfg commented Oct 16, 2017

#5

$('.intro-text').addClass('hidden');
});

player.addEventListener(Twitch.Player.OFFLINE, function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Twitch' is not defined.

}
var player = new Twitch.Player("video-player", options);

player.addEventListener(Twitch.Player.ONLINE, function() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Twitch' is not defined.

var options = {
channel: twitchUsername
}
var player = new Twitch.Player("video-player", options);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Twitch' is not defined.

js/main.js Outdated

player.addEventListener(Twitch.Player.OFFLINE, function() {
$('#video-player').addClass("hidden");
$('.intro-text').removeClass('hidden');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

js/main.js Outdated
});

player.addEventListener(Twitch.Player.OFFLINE, function() {
$('#video-player').addClass("hidden");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

js/main.js Outdated

player.addEventListener(Twitch.Player.ONLINE, function() {
$('#video-player').removeClass("hidden");
$('.intro-text').addClass('hidden');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

js/main.js Outdated
var player = new Twitch.Player("video-player", options);

player.addEventListener(Twitch.Player.ONLINE, function() {
$('#video-player').removeClass("hidden");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

js/main.js Outdated

var options = {
channel: twitchUsername
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

js/main.js Outdated

player.addEventListener(Twitch.Player.OFFLINE, function() {
$('#video-player').addClass('hidden');
$('.intro-text').removeClass('hidden');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

js/main.js Outdated
});

player.addEventListener(Twitch.Player.OFFLINE, function() {
$('#video-player').addClass('hidden');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

js/main.js Outdated

player.addEventListener(Twitch.Player.ONLINE, function() {
$('#video-player').removeClass('hidden');
$('.intro-text').addClass('hidden');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.

js/main.js Outdated
var player = new Twitch.Player("video-player", options);

player.addEventListener(Twitch.Player.ONLINE, function() {
$('#video-player').removeClass('hidden');
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mixed double and single quotes.


$.getJSON( "https://api.twitch.tv/kraken/channels/twitchusername/follows?client_id="+ clientId + "&callback=?", function(response) {
$('.followers span').text(response["_total"]);
$(".followers span").text(response["_total"]);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

['_total'] is better written in dot notation.

@Friss
Copy link
Owner

Friss commented Oct 16, 2017

Hey thanks for doing this! I'll take a look soon and we get get this merged in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants