fix: Stop sending URL encoded params in POST body #1401
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-georgiadis
requested review from
fulopdaniel,
imoutaharik and
oliverschwendener
🦋 Changeset detectedLatest commit: 13e1585 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
oliverschwendener
requested review from
mike85
and removed request for
oliverschwendener
marguslant0
approved these changes
Jan 20, 2026
| @@ -0,0 +1,5 @@ | |||
| --- | |||
| "@frontify/frontify-cli": major | |||
Contributor
Author
There was a problem hiding this comment.
@julianiff Is this what we're looking for?
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The SDK was passing the scope parameter in the body. It wasn't expected in the backend so no validation hit. Now that I added the scope in the backend the process throws an exception, because the body parameter of the POST request is URL encoded and we do not decode the body params on the backend