Support one script operator deployment#200
Merged
RobertIndie merged 1 commit intomainfrom Jun 29, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR supports a unified script operator deployment by introducing a consolidated deployment YAML and updating chart configuration and RBAC resource names for consistent naming. Key changes include the addition of an operator deployment YAML file, the introduction of a new createNamespace value in the Helm chart, and the renaming of several RBAC and deployment resources for consistency.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| operator/scripts/deploy.yaml | Adds comprehensive operator deployment resources generated from Helm templates. |
| operator/deploy/chart/values.yaml | Introduces a new createNamespace flag to control namespace creation. |
| Various chart templates (rbac, namespace, manager, etc.) | Renames resources to follow a consistent naming convention. |
| operator/Makefile | Adds a new target to generate the deploy YAML using helm template with appropriate flags. |
Comments suppressed due to low confidence (2)
operator/deploy/chart/values.yaml:44
- [nitpick] Consider adding inline documentation for the new 'createNamespace' field to clarify its usage and default behavior for users deploying the chart.
createNamespace: false
operator/deploy/chart/templates/manager/manager.yaml:4
- [nitpick] Verify that the change of the deployment name from 'operator-controller-manager' to 'function-stream' is intentional and consistently aligned with the naming of other operator resources.
name: function-stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.