feat: Add replicas field to Function CRD for configurable deployment scaling#202
Merged
RobertIndie merged 1 commit intomainfrom Jul 20, 2025
Merged
feat: Add replicas field to Function CRD for configurable deployment scaling#202RobertIndie merged 1 commit intomainfrom
RobertIndie merged 1 commit intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds a configurable replicas field to the Function CRD to enable horizontal scaling of function deployments, replacing the hardcoded single replica limit. The implementation maintains backward compatibility by defaulting to 1 replica when not specified.
- Added
replicasfield to FunctionSpec with proper validation and default value - Updated controller logic to use the specified replica count when creating deployments
- Added comprehensive test coverage for custom replicas, replica updates, and default behavior
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| operator/api/v1alpha1/function_types.go | Added replicas field to FunctionSpec struct with kubebuilder annotations |
| operator/internal/controller/function_controller.go | Updated reconciler to use configurable replicas instead of hardcoded value |
| operator/internal/controller/function_controller_test.go | Added comprehensive test cases for replica configuration scenarios |
| operator/api/v1alpha1/zz_generated.deepcopy.go | Updated generated deepcopy function to handle the new replicas pointer field |
| operator/config/crd/bases/fs.functionstream.github.io_functions.yaml | Updated CRD schema to include replicas field definition |
| operator/deploy/chart/templates/crd/fs.functionstream.github.io_functions.yaml | Updated Helm chart CRD template with replicas field |
| operator/scripts/deploy.yaml | Updated deployment YAML with replicas field schema |
RobertIndie
approved these changes
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Currently, Function deployments are hardcoded to use 1 replica, which limits the ability to scale functions based on workload requirements. This change adds a configurable
replicasfield to the Function CRD, allowing users to specify the desired number of replicas for their function deployments. This enables horizontal scaling of functions to handle increased load and improve availability.Modifications
replicasfield toFunctionSpecwith validation and default value of 1FunctionReconcilerto use the specified replicas when creating deployments.DS_Storeand._*files) to prevent accidental commitsThe implementation maintains backward compatibility by defaulting to 1 replica when the field is not specified, ensuring existing function deployments continue to work without modification.