feat: Support cross-namespace package references with PackageRef field#203
Merged
RobertIndie merged 3 commits intomainfrom Jul 20, 2025
Merged
feat: Support cross-namespace package references with PackageRef field#203RobertIndie merged 3 commits intomainfrom
RobertIndie merged 3 commits intomainfrom
Conversation
RobertIndie
approved these changes
Jul 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The current Function CRD uses a simple
Packagefield to reference packages, which limits the ability to reference packages from different namespaces. This change introduces a newPackageRefstructure that supports cross-namespace package references while maintaining backward compatibility and proper label management.The main problems this solves:
Modifications
Updated Function CRD structure:
Packagefield withPackageRefstructure containingNameandNamespacefieldsPackageRefstructureEnhanced webhook validation:
function_webhook.goto validate cross-namespace package referencesnamespace.package-name)Improved controller logic:
function_controller.goto handle cross-namespace package lookupsmapPackageToFunctionsto work with namespace-aware package labelsEnhanced test coverage:
PackageRefinstead ofPackageUpdated package webhook:
packages_webhook.goto use namespace-aware package labels when finding referencing functionsThe changes maintain backward compatibility while providing a more robust and flexible package reference system that supports cross-namespace operations.