feat: update Function CRD to use packageRef instead of package field#204
Merged
RobertIndie merged 1 commit intomainfrom Jul 21, 2025
Merged
feat: update Function CRD to use packageRef instead of package field#204RobertIndie merged 1 commit intomainfrom
RobertIndie merged 1 commit intomainfrom
Conversation
RobertIndie
approved these changes
Jul 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Function CRD was using a simple
packagefield as a string, which limited the ability to reference Package resources across namespaces and didn't follow Kubernetes best practices for resource references. This change updates the Function CRD to use a properpackageRefobject that includes both name and namespace fields, allowing for better resource management and cross-namespace package references.Modifications
packagefield from a simple string to apackageRefobject withnameandnamespacepropertiesoperator/DEVELOPER.mdexplaining the process for updating CRD definitions and ensuring Helm chart templates stay in syncoperator/deploy/chart/templates/crd/fs.functionstream.github.io_functions.yamlto reflect the new schema structureThe changes ensure that: