Merged
Conversation
Additionally fixing LDM issues where only if all parameters in a LDM subscription where set a result would be given.
daniel-ulied-i2cat
force-pushed
the
feature/gn-beacons
branch
from
49010a4 to
bb042e7
Compare
JordiMarias
requested changes
Feb 20, 2026
Collaborator
JordiMarias
left a comment
JordiMarias
left a comment
There was a problem hiding this comment.
Just small comments
| if self.ca_basic_service_ldm is not None: | ||
| self.ca_basic_service_ldm.add_provider_data_to_ldm(cam) | ||
| self.logging.debug( | ||
| self.logging.info( |
Collaborator
There was a problem hiding this comment.
This should be kept as debug logging. Technically, if you run the whole stack you don't expect to get an INFO print every time you receive a CAM message. This should be on a debug level.
|
|
||
| self.btp_router.btp_data_request(request) | ||
| self.logging.debug( | ||
| self.logging.info( |
| denm = self.denm_coder.decode(btp_indication.data) | ||
| self.feed_ldm(denm) | ||
| self.logging.debug( | ||
| self.logging.info( |
| ) | ||
| self.btp_router.btp_data_request(request) | ||
| self.logging.debug( | ||
| self.logging.info( |
| self.vru_basic_service_ldm.add_provider_data_to_ldm(vam) | ||
| self.logging.debug("Recieved message; %s", vam) | ||
| self.logging.debug( | ||
| self.logging.info( |
| ) | ||
| self.btp_router.btp_data_request(request) | ||
| self.logging.debug( | ||
| self.logging.info( |
| Encoded ST | ||
| """ | ||
| return (self.value << 3) << 8*7 | ||
| return (self.value << 2) << 8*7 |
Collaborator
There was a problem hiding this comment.
Has this been validated with wireshark?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally fixing LDM issues where only if all parameters in a LDM subscription where set a result would be given.