Skip to content

Conversation

@KoloInDaCrib
Copy link
Contributor

@KoloInDaCrib KoloInDaCrib commented Dec 5, 2025

Linked Issues

Nothing, heh, it's like that one soyjak gif.

Description

This PR makes it so that on targets that have the lime_vorbis feature flag enabled, freeplay previews will attempt to be loaded through the vorbis file first before using the regular partial sound method.

I'd love to make more things use streamed audio for optimization, though there are some roadblocks to this:

  1. Bugs, like a lot of them. From my testing, using too much streamed audio can sometimes cause the game to remove every audio, making the game silent, which I hope is an incredibly obvious problem for a rhythm game. The test was basically putting the vorbis loading method in FunkinSound's load and loadPartial functions, which also affected sound effects played through the playOnce function.
  2. Nene and her malice break the game, since streamed audio doesn't have any data to use for the A-Bot visualizer. ACrazyTown has made a PR on the funkVis repository feat: Add support for analyzing streamed OGG/Vorbis files funkVis#13 to fix the issue but it's been sitting there since april of this year.

Also if the code looks a bit ugly, that's because I had to apply endTime to the loaded sound so that it's actually a partial sound in a very specific position, since fading in the sound calls play without any arguments, which means that endTime is set to null and it makes the previews not partial anymore, spoiling the entire instrumental in the preview.............

Screenshots/Videos

smooth.scrolling.hell.yes.mp4

@github-actions github-actions bot added status: pending triage Awaiting review. size: medium A medium pull request with 100 or fewer changes. pr: haxe PR modifies game code. and removed status: pending triage Awaiting review. labels Dec 5, 2025
@KoloInDaCrib KoloInDaCrib force-pushed the i-wish-flixel-was-more-convenient branch from 5dc1941 to e6b5b6a Compare December 6, 2025 18:44
@Hundrec Hundrec added status: pending triage Awaiting review. type: optimization Involves a performance issue or a bug which causes lag. labels Dec 7, 2025
@KoloInDaCrib KoloInDaCrib force-pushed the i-wish-flixel-was-more-convenient branch from e6b5b6a to a87f000 Compare January 20, 2026 16:26
@Hundrec Hundrec force-pushed the develop branch 2 times, most recently from 3829dcb to 5805c31 Compare February 1, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: haxe PR modifies game code. size: medium A medium pull request with 100 or fewer changes. status: pending triage Awaiting review. type: optimization Involves a performance issue or a bug which causes lag.

Development

Successfully merging this pull request may close these issues.

3 participants