SoundInstance instead of fixed FlxG.sound.music #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will this EVER be merged |
it really should |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So currently LimeAudioClip only checks for the FlxG.sound.music time, but if we want a visualizer for an other sound instance... well it breaks...
So I changed the code to get the sound instance instead of the sound source... and allow to update the source without having to create a new visualiser from scratch.
(it also implies that you'll have to change the argument for SpectralAnalyzer from soundInstance._channel.__audioSource to soundInstance dirrectly)