feat(config): enable tool auto-execution by default#138
Merged
Conversation
Set skip_tool_confirmation default to true in AIConfig so new users get auto-execute enabled out of the box; add a dedicated serde default fn so the value is also correct when the field is absent from an existing config file. Mark DeleteFileTool and FileWriteTool as not requiring permissions (needs_permissions to false), aligning with the auto-execute default.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skip_tool_confirmationdefault totrueinAIConfigso new users get auto-execute enabled out of the boxdefault_skip_tool_confirmation()so the value is alsotruewhen the field is absent from an existing config fileDeleteFileToolandFileWriteToolneeds_permissionsasfalse, aligning them with the auto-execute defaultTest plan
skip_tool_confirmationfield: verify it defaults to enabled after upgrade