Conversation
frankfeifan
left a comment
There was a problem hiding this comment.
I think it's in a good shape. Will need to fix the styling issues and better to add some new baseline tests.
There was a problem hiding this comment.
Better to rename the xmls to something easier to understand the features of the example, e.g., 1D with interface, etc.
Also, I'd suggest adding some small problems to integrated tests.
There was a problem hiding this comment.
Same. I'd suggesting adding examples to integrated tests.
src/coreComponents/constitutive/electroChemistry/ButlerVolmerReaction.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/constitutive/electroChemistry/ButlerVolmerReaction.hpp
Outdated
Show resolved
Hide resolved
src/coreComponents/physicsSolvers/electrostatics/Electrostatics.cpp
Outdated
Show resolved
Hide resolved
| virtual void postInputInitialization() override; | ||
|
|
||
| string m_fieldName; | ||
| TimeIntegrationOption m_timeIntegrationOption; |
There was a problem hiding this comment.
Is m_timeIntegrationOption needed?
| }); | ||
| } | ||
|
|
||
| void Electrostatics::applyButlerVolmerCurrent(DofManager const& dofManager, DomainPartition& domain, |
There was a problem hiding this comment.
Better to make a kernel for it, but not urgent I think.
There was a problem hiding this comment.
I mimic the pattern in solid mechanics solver. It's a bit strange it has all the volume integration within kernels but the interface integration is implemented directly inside the solver like this.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #3698 +/- ##
===========================================
- Coverage 58.87% 58.75% -0.12%
===========================================
Files 1353 1366 +13
Lines 112953 113534 +581
===========================================
+ Hits 66504 66711 +207
- Misses 46449 46823 +374 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Initial implementation of electrostatics system with Butler-Volmer reaction computed with jumps on the split surface