Skip to content

rename marine suites, prepare for 3dvar_cf#32

Merged
Dooruk merged 45 commits intomainfrom
feature/rename_marine_suites
Mar 6, 2026
Merged

rename marine suites, prepare for 3dvar_cf#32
Dooruk merged 45 commits intomainfrom
feature/rename_marine_suites

Conversation

@Dooruk
Copy link
Collaborator

@Dooruk Dooruk commented Mar 5, 2026

The number of suites that CI-workflow is running is increasing. We should have the list line-by-line for readability (Couldn't use jq for brevity).

3dvar_cf is commented out until that PR is merged in SWELL and this PR can supersede #31

⚠️ GEOS-ESM/swell#677 Should go in before this can be merged.

@Dooruk Dooruk changed the title Feature/rename marine suites rename marine suites, prepare for 3dvar_cf Mar 5, 2026
@Dooruk Dooruk marked this pull request as ready for review March 5, 2026 19:53
@Dooruk Dooruk requested a review from a team as a code owner March 5, 2026 19:53
@Dooruk Dooruk requested a review from mranst March 5, 2026 19:53
@Dooruk
Copy link
Collaborator Author

Dooruk commented Mar 5, 2026

.test_swell.yml changes shouldn't matter...

Copy link
Collaborator

@mranst mranst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once GEOS-ESM/swell#677 goes in. Does .github/test_swell.yml have a function? Maybe we can just remove it

@Dooruk
Copy link
Collaborator Author

Dooruk commented Mar 6, 2026

Looks good once GEOS-ESM/swell#677 goes in. Does .github/test_swell.yml have a function? Maybe we can just remove it

Nothing other than confusing people, we should remove it 😄

@Dooruk Dooruk merged commit 2483dab into main Mar 6, 2026
@Dooruk Dooruk deleted the feature/rename_marine_suites branch March 6, 2026 22:07
@jardizzo
Copy link
Collaborator

jardizzo commented Mar 6, 2026

Looks good once GEOS-ESM/swell#677 goes in. Does .github/test_swell.yml have a function? Maybe we can just remove it

Nothing other than confusing people, we should remove it 😄

I think test_swell was a placeholder for testing since it is approved as a valid workflow for the runners:

GEOS-ESM/CI-workflows/.github/workflows/discover-validate.yml@refs/heads/main,
GEOS-ESM/CI-workflows/.github/workflows/geosongpu-ondemand.yml@refs/heads/project/geosongpu,
GEOS-ESM/CI-workflows/.github/workflows/nag-build.yml@refs/heads/project/mapl,
GEOS-ESM/CI-workflows/.github/workflows/swell-tier1_application_discover.yml@refs/heads/main,
GEOS-ESM/CI-workflows/.github/workflows/swell-tier2_application_discover.yml@refs/heads/main,
GEOS-ESM/CI-workflows/.github/workflows/test_swell.yml@refs/heads/feature/test_swell_application

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants