Skip to content

Use Fortran pointer’s contiguous attribute #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pchakraborty merged 2 commits into from
Jan 14, 2026
Merged

Use Fortran pointer’s contiguous attribute #336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d14b271
Revert "Back to using MAPL_RemapBounds - gfortran has trouble with bo…
pchakraborty Jan 14, 2026
6a0425c
Using pointer's contiguous attribute to try to get around gfortran issue
pchakraborty Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions DynCore_GridCompMod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,6 @@ module FVdycoreCubed_GridComp
use MAPL_AbstractRegridderMod, only: AbstractRegridder
! pchakrab - TODO: need MAPL3 equivalent
! use MAPL_SunMod, only: MAPL_SunOrbit, MAPL_SunGetInsolation
use MAPL_BaseMod, only: MAPL_RemapBounds
use MAPL_GridManagerMod, only: grid_manager
use MAPL_RegridderManagerMod, only: regridder_manager
use MAPL_RegridMethods, only: REGRID_METHOD_BILINEAR
Expand Down Expand Up @@ -3544,7 +3543,7 @@ subroutine PULL_Q(self, import, QQQ, iNXQ, InFieldName, rc)
type(ESMF_Field) :: field
type(ESMF_Array) :: array
type(ESMF_TypeKind_Flag) :: kind
real(r4), pointer :: ptr_r4(:,:,:)
real(r4), pointer, contiguous :: ptr_r4(:,:,:)
real(r8), pointer :: ptr_r8(:,:,:)
integer :: N,NQ
integer :: i1, in, j1, jn, im, jm, km
Expand Down Expand Up @@ -3584,10 +3583,7 @@ subroutine PULL_Q(self, import, QQQ, iNXQ, InFieldName, rc)
self%vars%TRACER(N)%TNAME = fieldname
if ( self%vars%TRACER(N)%IS_R4 ) then
call ESMF_ArrayGet(array, localDE=0, farrayptr=ptr_r4, _RC)
! gfortran has trouble with pointer bounds remapping
! (Error: Rank remapping target must be rank 1 or simply contiguous)
! self%vars%tracer(n)%content_r4(i1:in, j1:jn, 1:km) => ptr_r4
self%vars%tracer(n)%content_r4 => MAPL_RemapBounds(ptr_r4, i1, in, j1, jn, 1, km)
self%vars%tracer(n)%content_r4(i1:in, j1:jn, 1:km) => ptr_r4
if (fieldname == QFieldName) then
qqq%is_r4 = .true.
qqq%content_r4 => self%vars%tracer(n)%content_r4
Expand Down
Loading