Skip to content

v11: Fix for lnfm.data symlink#809

Open
mathomp4 wants to merge 1 commit intodevelopfrom
bugfix/v11-lnfm-fix
Open

v11: Fix for lnfm.data symlink#809
mathomp4 wants to merge 1 commit intodevelopfrom
bugfix/v11-lnfm-fix

Conversation

@mathomp4
Copy link
Member

@sshakoor1 found a bug in linkbcs where if CatchCN was on a symlink was incorrect:

> lt /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/v11/CF0024x6C_DE1440xPE0720/lnfm_clim_24x144.data
"/discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/v11/CF0024x6C_DE1440xPE0720/lnfm_clim_24x144.data": No such file or directory (os error 2)

the line was missing the land/:

> lt /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/v11/land/CF0024x6C_DE1440xPE0720/lnfm_clim_24x144.data
Permissions Size User     Group  Date Modified    Name
.r-xrwxr-x   19M borescan bcsgen 2023-10-12 15:27  /discover/nobackup/projects/gmao/bcs_shared/fvInput/ExtData/esm/tiles/v11/land/CF0024x6C_DE1440xPE0720/lnfm_clim_24x144.data*

This fixes that path.

@mathomp4 mathomp4 self-assigned this Feb 20, 2026
@mathomp4 mathomp4 requested a review from a team as a code owner February 20, 2026 20:39
@mathomp4 mathomp4 added the 0 diff The changes in this pull request have verified to be zero-diff with the target branch. label Feb 20, 2026
Copy link
Contributor

@gmao-rreichle gmao-rreichle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure when this was missed, but the fix looks correct. Also not sure if this file is even used in CatchCN simulations. That'd require some digging, which isn't worth the effort. Perhaps @biljanaorescanin knows off the top of her head. I also don't know if anyone actually uses CatchCN with the GCM (as opposed to offline with GEOSldas) at this time.

In any case, best to merge the fix, it can't hurt.

@biljanaorescanin
Copy link
Contributor

biljanaorescanin commented Feb 20, 2026

@gmao-rreichle - lnfm (lightning frequency) is used with CatchCN.

I think the files specific to CatchCN from BCs are:
CLM_NDep_SoilAlb_T2m
CLM_veg_typs_fracs
lnfm.dat

  • Maybe some scaling as well...depending how you setup run.

Not sure when this got broken... But tnx for fix @mathomp4 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0 diff The changes in this pull request have verified to be zero-diff with the target branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants