Open
Conversation
gmao-rreichle
approved these changes
Feb 20, 2026
Contributor
gmao-rreichle
left a comment
There was a problem hiding this comment.
Not sure when this was missed, but the fix looks correct. Also not sure if this file is even used in CatchCN simulations. That'd require some digging, which isn't worth the effort. Perhaps @biljanaorescanin knows off the top of her head. I also don't know if anyone actually uses CatchCN with the GCM (as opposed to offline with GEOSldas) at this time.
In any case, best to merge the fix, it can't hurt.
Contributor
|
@gmao-rreichle - I think the files specific to CatchCN from BCs are:
Not sure when this got broken... But tnx for fix @mathomp4 ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@sshakoor1 found a bug in linkbcs where if CatchCN was on a symlink was incorrect:
the line was missing the
land/:This fixes that path.