Run ISSM over multiple input files (multiple ice sheets or glaciers)#1216
Merged
agstub merged 2 commits intofeature/agstub/issm-gridcompfrom Feb 24, 2026
Merged
Conversation
|
This PR is being prevented from merging because you have not added one of our required labels: 0 diff, 0 diff trivial, Non 0-diff, 0 diff structural, 0-diff trivial, Not 0-diff, 0-diff, automatic, 0-diff uncoupled, github_actions. Please add one so that the PR can be merged. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the (small) GEOSgcm_GridComp changes accompanying this merged PR:
Most importantly, all we have to supply ISSM from the GEOS side is the directory ISSM_EXPDIR, which ISSM scans for input files and creates a FemModel object for each input (glacier or ice sheet) it finds. A global mesh is constructed from all of the models in GEOS/ESMF sides (with global import/export pointers), and import/export pointers are split up appropriately over models and processes on the ISSM side.
A new variable "glacIds" is added to the saved mesh file (issm_mesh.nc). For each element, glacIds stores an integer ID corresponding to the glacier (starting from 0, sorting the input files alphabetically)