New home for MAPL_GetHorzIJIndex - in geom, as MAPL_GridGetHorzIJIndex#4476
Draft
pchakraborty wants to merge 9 commits intorelease/MAPL-v3from
Draft
New home for MAPL_GetHorzIJIndex - in geom, as MAPL_GridGetHorzIJIndex#4476pchakraborty wants to merge 9 commits intorelease/MAPL-v3from
pchakraborty wants to merge 9 commits intorelease/MAPL-v3from
Conversation
… a grid query routine belongs in geom
…omms re-formatted by codee
…hakrab/get-horz-ij-index
pchakraborty
added
0 Diff
tclune
reviewed
Mar 3, 2026
Comment on lines
+97
to
+105
| ! Set input points (in radians) | ||
| lonR8(1) = 0.0d0 | ||
| latR8(1) = 0.0d0 | ||
| lonR8(2) = 1.5707963267948966d0 ! pi/2 | ||
| latR8(2) = 0.7853981633974483d0 ! pi/4 | ||
| lonR8(3) = 3.1415926535897932d0 ! pi | ||
| latR8(3) = -0.7853981633974483d0 ! -pi/4 | ||
| lonR8(4) = -1.5707963267948966d0 ! -pi/2 | ||
| latR8(4) = 1.5707963267948966d0 ! pi/2 (north pole) |
Collaborator
There was a problem hiding this comment.
Not worth fixing, but ... why not use pi/2 and such directly rather than putting in the decimal representation? Apologies if this was a pre-existing test that you only copied.
tclune
previously approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Types of change(s)
Checklist
make tests)Description
Ported
MAPL_GetHorzIJIndexfrombasetogeom. Renamed asMAPL_GridGetHorzIJIndexNote
Goal is for each grid kind (lat-lon, cubed-sphere, etc.) to have its own implementation of
GridGetHorzIJIndex. This is to be addressed in a separate PRRelated Issue
#4475