Update Bracket aspect ordering to include new normalization aspects (issue #4482)#4485
Open
tclune wants to merge 2 commits intointegration/conservative-regriddingfrom
Open
Conversation
Adds the three new aspects (QuantityType, Normalization, InverseNormalization) to the aspect ordering in BracketClassAspect and VectorBracketClassAspect to match FieldClassAspect and FieldBundleClassAspect. These aspects were added in PR #4480 (Task 2.7) but Bracket classes were inadvertently omitted. This ensures consistent aspect ordering across all ClassAspect implementations for conservative regridding support. Changes: - BracketClassAspect::get_aspect_order() now returns complete aspect list - VectorBracketClassAspect::get_aspect_order() now returns complete aspect list - Removed time-dependent conditional logic (simplified to match Field/FieldBundle) Fixes #4482
tclune
added
📈 MAPL3
Add QuantityTypeAspect and NormalizationAspect to BracketClassAspect and VectorBracketClassAspect get_aspect_order() methods to align with FieldClassAspect and FieldBundleClassAspect. These aspects come before GEOM_ASPECT_ID in the ordering. The conditional logic for time-dependent geometries is preserved, with CLASS/GEOM order swapping based on whether time interpolation is needed. Fixes #4482
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the three new aspects (QuantityType, Normalization, InverseNormalization) to the aspect ordering in BracketClassAspect and VectorBracketClassAspect to match FieldClassAspect and FieldBundleClassAspect.
These aspects were added in PR #4480 (Task 2.7: Update Aspect Ordering for Normalization) but Bracket classes were inadvertently omitted from that update.
Changes
Why This Matters
The get_aspect_order() method determines the ORDER in which couplers/transforms are applied during state item connections. Having an incomplete aspect ordering in Bracket classes could cause:
Testing
Related
Fixes #4482