Skip to content

Conversation

@najlkin
Copy link
Contributor

@najlkin najlkin commented Jun 3, 2025

Fixed reset of sol* vectors for visualization scene, which caused crashes like in #341 .

@najlkin najlkin requested a review from camierjs June 3, 2025 20:24
@najlkin najlkin self-assigned this Jun 3, 2025
@najlkin najlkin added the bug label Jun 3, 2025
@najlkin najlkin linked an issue Jun 3, 2025 that may be closed by this pull request
@najlkin najlkin mentioned this pull request Jun 3, 2025
Copy link

@camierjs camierjs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @najlkin !

@najlkin najlkin requested a review from tzanio June 3, 2025 21:52
@najlkin
Copy link
Contributor Author

najlkin commented Jun 4, 2025

Note that this is a simple fix, a better solution connected with some refactoring is done in #335 .

camierjs added a commit that referenced this pull request Jun 9, 2025
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @najlkin !

@tzanio tzanio merged commit fde9dfd into master Jun 17, 2025
10 checks passed
@tzanio tzanio deleted the fix-data-reset branch June 17, 2025 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

f command crashes app

4 participants