Conversation
- PRテンプレートの追加 - プロジェクトルールに基づくチェックリスト - テスト要件の確認項目 - コーディング規約の確認項目 - Git運用フローのドキュメント作成 - ブランチ戦略の詳細化 - コミットメッセージの規約 - PRレビュープロセス - CI/CD連携 Issue #28 対応
- AppError、NetworkError、LLMError、ConfigError、ProxyErrorのテストを追加 - エラーハンドリングミドルウェアのテストを追加 - カバレッジを100%に改善 - エラーレスポンスの型安全性を向上
There was a problem hiding this comment.
Pull Request Overview
This PR improves error handling test coverage by adding tests for various error classes and the error-handling middleware, and updates error messages with standardized error codes. Key changes include updates to test files for error classes, modifications to error construction in the FilterService, and documentation updates covering the PR template and Git workflow.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| .github/pull_request_template.md | Added and updated sections for improved PR detail guidance |
| docs/git-workflow.md | Added comprehensive Git workflow guidelines |
| src/utils/tests/errors.test.ts | Updated error class tests; merge conflict markers need resolution |
| src/services/filter-service.ts | Updated error instantiation with consistent error codes |
| src/proxy/tests/error-handler.test.ts | Maintained middleware test functionality |
Comments suppressed due to low confidence (1)
src/utils/tests/errors.test.ts:4
- Unresolved merge conflict markers found in this file. Please resolve the conflicts and remove all merge markers (e.g., <<<<<<<, =======, >>>>>>>) before merging.
<<<<<<< HEAD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容
エラーハンドリング機能のテストを追加し、カバレッジを改善しました。
追加したテスト
カバレッジ改善
変更ファイル