Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR removes all CI/CD and test-related files and configurations to streamline the development environment. Key changes include modifying the AppError constructor in src/utils/errors.ts, updating type annotations in src/middleware/filter-middleware.ts, and deleting numerous test files across the project.
Reviewed Changes
Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/errors.ts | Modifies the AppError constructor to accept either a string code or metadata object; however, a duplicate assignment may override the intended metadata value. |
| src/middleware/filter-middleware.ts | Updates type annotations by replacing type aliases with interfaces and using “unknown” instead of “any”. |
| Various tests directories/files | Deletes test files and related configurations from CI/CD and test infrastructure. |
Files not reviewed (1)
- package.json: Language not supported
| this.code = code; | ||
| if (typeof codeOrMetadata === 'string') { | ||
| this.code = codeOrMetadata; | ||
| this.metadata = metadata; |
There was a problem hiding this comment.
This assignment overwrites the metadata set in the conditional block above. Consider removing this duplicate assignment to ensure the intended metadata value is preserved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容\n\n- CI/CD関連の設定とテスト関連ファイルをすべて削除\n- package.jsonからテスト関連のスクリプトと依存関係を削除\n- Jest設定ファイルを削除\n- すべてのテストディレクトリ(tests)を削除\n\n## 理由\n\nテスト環境の簡素化と開発効率の向上のため