Skip to content

CI/CDテストとテスト関連ファイルの削除#32

Merged
GOROman merged 1 commit intomainfrom
feature/remove-tests
Mar 21, 2025
Merged

CI/CDテストとテスト関連ファイルの削除#32
GOROman merged 1 commit intomainfrom
feature/remove-tests

Conversation

@GOROman
Copy link
Owner

@GOROman GOROman commented Mar 21, 2025

変更内容\n\n- CI/CD関連の設定とテスト関連ファイルをすべて削除\n- package.jsonからテスト関連のスクリプトと依存関係を削除\n- Jest設定ファイルを削除\n- すべてのテストディレクトリ(tests)を削除\n\n## 理由\n\nテスト環境の簡素化と開発効率の向上のため

@GOROman GOROman requested a review from Copilot March 21, 2025 08:58
@GOROman GOROman merged commit 1338e32 into main Mar 21, 2025
0 of 3 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all CI/CD and test-related files and configurations to streamline the development environment. Key changes include modifying the AppError constructor in src/utils/errors.ts, updating type annotations in src/middleware/filter-middleware.ts, and deleting numerous test files across the project.

Reviewed Changes

Copilot reviewed 19 out of 20 changed files in this pull request and generated 1 comment.

File Description
src/utils/errors.ts Modifies the AppError constructor to accept either a string code or metadata object; however, a duplicate assignment may override the intended metadata value.
src/middleware/filter-middleware.ts Updates type annotations by replacing type aliases with interfaces and using “unknown” instead of “any”.
Various tests directories/files Deletes test files and related configurations from CI/CD and test infrastructure.
Files not reviewed (1)
  • package.json: Language not supported

this.code = code;
if (typeof codeOrMetadata === 'string') {
this.code = codeOrMetadata;
this.metadata = metadata;
Copy link

Copilot AI Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assignment overwrites the metadata set in the conditional block above. Consider removing this duplicate assignment to ensure the intended metadata value is preserved.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants