Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough여러 컨트롤러의 클래스·메서드 레벨 RequestMapping 경로를 일관된 버전화된 API 구조(예: Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Suggested reviewers
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: Repository UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 8
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/controller/StoreController.java (1)
36-41: 메서드명 불일치로 인한 컴파일 오류 발생컨트롤러 메서드명은
getAllStoresByPageAndDepartments로 변경되었지만(Line 36), 서비스 호출은 여전히 이전 오타가 있는 메서드명getAllStoresByPageAndDeparments를 사용하고 있습니다(Line 41). 이는 컴파일 오류를 발생시킵니다.🔎 수정 제안
public ResponseEntity<?> getAllStoresByPageAndDepartments(Pageable pageable, @AuthenticationPrincipal CustomOAuth2User customOAuth2User) { return ResponseEntity .ok() .body( ApiUtils.success( - storeService.getAllStoresByPageAndDeparments(pageable, customOAuth2User) + storeService.getAllStoresByPageAndDepartments(pageable, customOAuth2User) ) ); }
🧹 Nitpick comments (1)
nowait-app-user-api/src/main/java/com/nowait/applicationuser/order/controller/OrderController.java (1)
35-51: 주석 처리된 코드 제거 권장더 이상 사용되지 않는 주석 처리된 코드는 삭제하는 것이 좋습니다. 필요시 Git 히스토리를 통해 언제든지 확인할 수 있습니다.
🔎 제안하는 수정사항
- // @PostMapping("/create/{storeId}/{tableId}") - // @Operation(summary = "주문 생성", description = "특정 주점 - 특정 테이블에 대한 주문 생성") - // @ApiResponse(responseCode = "201", description = "주문 생성") - // public ResponseEntity<?> createOrder( - // @PathVariable Long storeId, - // @PathVariable Long tableId, - // @RequestBody @Valid OrderCreateRequestDto orderCreateRequestDto, - // HttpSession session - // ) { - // String sessionId = session.getId(); - // OrderCreateResponseDto response = orderService.createOrder(storeId, tableId, orderCreateRequestDto, sessionId); - // return ResponseEntity - // .status(HttpStatus.CREATED) - // .body( - // ApiUtils.success(response) - // ); - // } - @PostMapping
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (9)
nowait-app-user-api/src/main/java/com/nowait/applicationuser/bookmark/controller/BookmarkController.java(1 hunks)nowait-app-user-api/src/main/java/com/nowait/applicationuser/menu/controller/MenuController.java(2 hunks)nowait-app-user-api/src/main/java/com/nowait/applicationuser/oauth/controller/KakaoAppAuthController.java(1 hunks)nowait-app-user-api/src/main/java/com/nowait/applicationuser/order/controller/OrderController.java(3 hunks)nowait-app-user-api/src/main/java/com/nowait/applicationuser/reservation/controller/ReservationController.java(5 hunks)nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/controller/StoreController.java(2 hunks)nowait-app-user-api/src/main/java/com/nowait/applicationuser/storepayment/controller/StorePaymentController.java(1 hunks)nowait-app-user-api/src/main/java/com/nowait/applicationuser/token/controller/TokenController.java(1 hunks)nowait-app-user-api/src/main/java/com/nowait/applicationuser/user/controller/UserController.java(1 hunks)
🧰 Additional context used
🧬 Code graph analysis (1)
nowait-app-user-api/src/main/java/com/nowait/applicationuser/storepayment/controller/StorePaymentController.java (2)
nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/controller/StoreController.java (1)
Tag(23-87)nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/controller/StorePaymentController.java (1)
Tag(31-92)
🔇 Additional comments (10)
nowait-app-user-api/src/main/java/com/nowait/applicationuser/reservation/controller/ReservationController.java (5)
31-31: LGTM!버전화된 API 경로(
/v1/users/me/waitings)가 RESTful 컨벤션과 PR의 일관성 목표에 잘 부합합니다.
37-39: LGTM!레거시 엔드포인트를 성능 비교 목적으로 유지하면서
/legacy/접두사로 명확하게 구분하고, 주석과@Operation어노테이션으로 목적을 잘 문서화했습니다.
54-54: LGTM!대기열 등록 엔드포인트가 간결하고 RESTful한 경로로 잘 정리되었습니다.
72-72: LGTM!대기열 조회 엔드포인트가 RESTful 패턴에 맞게 잘 정리되었습니다.
106-106: LGTM!기본 경로에서 전체 대기열 목록을 조회하는 방식이 RESTful 패턴에 잘 부합합니다.
nowait-app-user-api/src/main/java/com/nowait/applicationuser/store/controller/StoreController.java (2)
25-25: 경로 수정 확인클래스 레벨 매핑에 선행 슬래시가 추가되어 올바른 경로 형식이 되었습니다.
72-72: 엔드포인트 경로 변경 완료 확인됨
/waiting-count엔드포인트가 StoreController.java 72번 줄에 올바르게 정의되어 있으며, 전체 코드베이스에서 이전/waiting-list경로에 대한 참조가 없습니다. 엔드포인트 변경이 성공적으로 완료되었습니다.nowait-app-user-api/src/main/java/com/nowait/applicationuser/storepayment/controller/StorePaymentController.java (1)
31-47: 응답 처리 개선 확인결제 정보가 없을 때 204 No Content를 반환하도록 개선되었습니다. 이는 RESTful API 설계 원칙에 부합하는 좋은 변경입니다.
nowait-app-user-api/src/main/java/com/nowait/applicationuser/user/controller/UserController.java (2)
28-31: 파라미터 네이밍 개선파라미터명이
req에서request로 변경되어 가독성이 향상되었습니다.
19-19: 사용자 중심 API 구조로 개선됨기본 경로가
/v1/users/me로 변경되어 사용자별 리소스를 명확하게 표현합니다. 엔드포인트는/v1/users/me/optional이 됩니다. 이는 BookmarkController(/v1/users/me/bookmarks), ReservationController(/v1/users/me/waitings) 등 다른 사용자 관련 컨트롤러와 일관된 패턴입니다.
...ser-api/src/main/java/com/nowait/applicationuser/bookmark/controller/BookmarkController.java
Outdated
Show resolved
Hide resolved
...it-app-user-api/src/main/java/com/nowait/applicationuser/menu/controller/MenuController.java
Show resolved
Hide resolved
...er-api/src/main/java/com/nowait/applicationuser/oauth/controller/KakaoAppAuthController.java
Show resolved
Hide resolved
...-app-user-api/src/main/java/com/nowait/applicationuser/order/controller/OrderController.java
Show resolved
Hide resolved
...i/src/main/java/com/nowait/applicationuser/reservation/controller/ReservationController.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/nowait/applicationuser/storepayment/controller/StorePaymentController.java
Outdated
Show resolved
Hide resolved
...src/main/java/com/nowait/applicationuser/storepayment/controller/StorePaymentController.java
Outdated
Show resolved
Hide resolved
...-app-user-api/src/main/java/com/nowait/applicationuser/token/controller/TokenController.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 요약
Issue Link
#338
문제점 및 어려움
해결 방안
Reference
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.