Skip to content

Refactor : waiting code review #356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jjiggu merged 2 commits into from
Feb 1, 2026
Merged

Refactor : waiting code review #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
117fa93
refactor: 코드 매핑 수정
Jjiggu Feb 1, 2026
d00b1c5
refactor: 멱등성 조회 로직 순서 조정
Jjiggu Feb 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...p-user-api/src/main/java/com/nowait/applicationuser/exception/GlobalExceptionHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ public ErrorResponse duplicateReservationException(DuplicateReservationException
public ErrorResponse alreadyWaitingException(AlreadyDeletedWaitingException e, WebRequest request) {
alarm(e, request);
log.error("alreadyWaitingException", e);
return new ErrorResponse(e.getMessage(), DUPLICATE_RESERVATION.getCode());
return new ErrorResponse(e.getMessage(), ALREADY_DELETED_RESERVATION.getCode());
}

@ResponseStatus(BAD_REQUEST)
Expand Down
17 changes: 9 additions & 8 deletions ...app-user-api/src/main/java/com/nowait/applicationuser/waiting/service/WaitingService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,15 @@ public class WaitingService {
@Transactional
public RegisterWaitingResponse registerWaiting(CustomOAuth2User oAuth2User, String publicCode, RegisterWaitingRequest waitingRequest, HttpServletRequest httpServletRequest) {

String idempotentKey = httpServletRequest.getHeader("Idempotency-Key");

// TODO 멱등성 검증 로직 점검 필요
Optional<WaitingIdempotencyValue> existingIdempotencyValue = waitingIdempotencyRepository.findByKey(idempotentKey);
if (existingIdempotencyValue.isPresent()) {
log.info("Existing idempotency key found: {}", idempotentKey);
return existingIdempotencyValue.get().getResponse();
}

// TODO 유저 및 주점 존재 검증은 공통으로 많이 쓰이니 AOP로 빼는게 좋을 듯
Store store = storeRepository.findByPublicCodeAndDeletedFalse(publicCode)
.orElseThrow(StoreNotFoundException::new);
Expand All @@ -65,18 +74,10 @@ public RegisterWaitingResponse registerWaiting(CustomOAuth2User oAuth2User, Stri
Long storeId = store.getStoreId();
LocalDateTime timestamp = LocalDateTime.now();
String waitingNumber = generateWaitingNumber(storeId, timestamp);
String idempotentKey = httpServletRequest.getHeader("Idempotency-Key");

// 멱등키 검증 - 이미 동일한 멱등키로 등록된 웨이팅이 있는지 확인
// waitingRedisRepository.idempotentKeyKeyExists(idempotentKey, ReservationStatus.WAITING.name());

// TODO 멱등성 검증 로직 점검 필요
Optional<WaitingIdempotencyValue> existingIdempotencyValue = waitingIdempotencyRepository.findByKey(idempotentKey);
if (existingIdempotencyValue.isPresent()) {
log.info("Existing idempotency key found: {}", idempotentKey);
return existingIdempotencyValue.get().getResponse();
}


// 일일 가능 웨이팅 최대 개수 초과 검증
// TODO race condition 발생 가능성 점검 필요
Expand Down