Develop

[hwangdae]

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

Release Notes

• New Features

  • Added notification modal for maximum waiting reservations limit.

• Improvements

  • Reorganized store detail page layout into dedicated sections for better visual clarity.
  • Enhanced loading and error state handling across waiting-related pages.
  • Improved error display with consistent NotFound component.
  • Fixed add menu button icon alignment.
  • Refined bookmark state management.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR refactors the waiting and store detail pages into modular, hook-based architectures. It extracts data-fetching and business logic into custom hooks (useWaitingSummary, useStoreDetail), replaces inline component logic with dedicated presentational components, updates the bookmark type structure, and applies minor styling adjustments.

Changes

Cohort / File(s)	Summary
CartList styling apps/nowait-user/src/pages/order/orderList/components/CartList.tsx	Added flexbox container wrapping SVG icon to center alignment within Add button
WaitingSummaryPage refactoring apps/nowait-user/src/pages/waiting/WaitingSummary/WaitingSummaryPage.tsx	Replaced direct API calls with useWaitingSummary hook; renamed submission handler; replaced Portal modal with MaxReservationModal component; delegated UI rendering to new WaitingStoreSummary and WaitingGuide components
New waiting summary components apps/nowait-user/src/pages/waiting/WaitingSummary/components/MaxReservationModal.tsx, WaitingGuide.tsx, WaitingStoreSummary.tsx	Three new presentational components: modal for reservation limit alerts, guide section renderer, and store summary card
useWaitingSummary hook apps/nowait-user/src/pages/waiting/WaitingSummary/hooks/useWaitingSummary.ts	New hook centralizing store and reservation data fetching, reservation limit checks, and waiting creation logic
StoreDetailPage refactoring apps/nowait-user/src/pages/waiting/storeDetail/StoreDetailPage.tsx	Replaced inline data fetching with useStoreDetail hook; split inline UI into StoreHeaderSection, StoreInfoSection, and StoreActionSection components; added loading and error guards
New store detail components apps/nowait-user/src/pages/waiting/storeDetail/components/StoreActionSection.tsx, StoreHeaderSection.tsx, StoreInfoSection.tsx	Three new presentational components: footer actions (bookmark/waiting buttons), header banner and info display, and store details (location/hours/notice)
useStoreDetail hook apps/nowait-user/src/pages/waiting/storeDetail/hooks/useStoreDetail.ts	New hook managing store data fetching, bookmark state subscription, toggle logic, and scroll-to-top behavior
Bookmark type updates apps/nowait-user/src/types/wait/store.ts	Changed StoreResponse bookmark field from isBookmarked: boolean to bookmarkId: number and isBookmark: boolean; renamed StoreType isBookmark to isBookmarked and added bookmarkId
Error handling updates apps/nowait-user/src/pages/waiting/bookmark/BookmarkPage.tsx	Replaced error UI div with <NotFound /> component
Button borderColor adjustment packages/ui/src/button.tsx	Changed borderColor fallback logic from borderColor || undefined to direct assignment

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Possibly related PRs

• feat: 웨이팅, 주문 페이지 수정사항 반영 #466: Directly modifies waiting/order codebase with getMyReservations, useWaitingSummary, MaxReservationModal, and summary components—same functional scope
• Develop #392: Updates store detail data flow with useStoreDetail hook and refactors StoreDetailPage similar structure
• Develop #548: Modifies CartList.tsx Add button icon rendering, same file as this PR

Suggested reviewers

• oriNuguri25
• dgKim1

Poem

🐰 Hooks and components, hop by hop,
Data flows smooth, no more direct stop,
Modular magic in waiting lines,
Store details shine with new designs! ✨

✨ Finishing touches

• 📝 Generate docstrings

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bf37316 and 419c847.

📒 Files selected for processing (14)

• apps/nowait-user/src/pages/order/orderList/components/CartList.tsx
• apps/nowait-user/src/pages/waiting/WaitingSummary/WaitingSummaryPage.tsx
• apps/nowait-user/src/pages/waiting/WaitingSummary/components/MaxReservationModal.tsx
• apps/nowait-user/src/pages/waiting/WaitingSummary/components/WaitingGuide.tsx
• apps/nowait-user/src/pages/waiting/WaitingSummary/components/WaitingStoreSummary.tsx
• apps/nowait-user/src/pages/waiting/WaitingSummary/hooks/useWaitingSummary.ts
• apps/nowait-user/src/pages/waiting/bookmark/BookmarkPage.tsx
• apps/nowait-user/src/pages/waiting/storeDetail/StoreDetailPage.tsx
• apps/nowait-user/src/pages/waiting/storeDetail/components/StoreActionSection.tsx
• apps/nowait-user/src/pages/waiting/storeDetail/components/StoreHeaderSection.tsx
• apps/nowait-user/src/pages/waiting/storeDetail/components/StoreInfoSection.tsx
• apps/nowait-user/src/pages/waiting/storeDetail/hooks/useStoreDetail.ts
• apps/nowait-user/src/types/wait/store.ts
• packages/ui/src/button.tsx

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}