Skip to content

API 경로 수정#565

Merged
hwangdae merged 7 commits intomainfrom
develop
Jan 15, 2026
Merged

API 경로 수정#565
hwangdae merged 7 commits intomainfrom
develop

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Jan 15, 2026

작업 내용

order, menu, waiting API 경로 수정

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • Performance Improvements

    • Optimized font loading with preloading and local hosting for faster page renders
    • Enhanced caching configuration for booth data to reduce unnecessary refreshes
    • Added long-term cache headers for static assets
  • API Updates

    • Updated API endpoints to v1 across menu, order, and reservation services for improved backend compatibility

✏️ Tip: You can customize this high-level summary in your review settings.

@hwangdae hwangdae merged commit ede3deb into main Jan 15, 2026
2 of 3 checks passed
@github-actions github-actions bot requested a review from dgKim1 January 15, 2026 09:03
@coderabbitai
Copy link

coderabbitai bot commented Jan 15, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR introduces Pretendard Variable font assets and configuration for both admin and user apps, updates API endpoints to v1 versioning across multiple user app modules, optimizes a React component with memoization, configures cache headers for font assets, and updates font imports.

Changes

Cohort / File(s) Summary
Font Asset Setup
apps/nowait-admin/index.html, apps/nowait-user/index.html
Added preload links for Pretendard Variable font and introduced leading BOM character before DOCTYPE declarations.
Pretendard CSS Definitions
apps/nowait-admin/public/fonts/pretendard/pretendardvariable.css, apps/nowait-user/public/fonts/pretendard/pretendardvariable.css
New @font-face declarations for Pretendard Variable with weight range 100-900, WOFF2 format sourcing, and font-display swap. Includes commented-out italic variant blocks.
Shared Font Import Configuration
packages/tailwind-config/shared-styles.css
Changed external CDN font import to local path (/fonts/pretendard/pretendardvariable.css). Updated comment text and added trailing newline.
API Endpoint Updates (v1 Versioning)
apps/nowait-user/src/api/menu.ts, apps/nowait-user/src/api/order.ts, apps/nowait-user/src/api/reservation.ts
Prefixed endpoints with /v1 across all API calls. Modified getInfiniteAllStores return value to access response.data.response instead of response.data.
Component Optimization
apps/nowait-admin/src/pages/AdminOrders/AdminOrders.tsx
Introduced useMemo hook to memoize data derivation; consolidated three separate filter operations into single memoized computation for paymentWaitingData, cookingData, and cookedData.
Query Cache Configuration
apps/nowait-user/src/pages/waiting/boothMap/hooks/useBooths.ts
Extended cache validity window from 60 seconds to 5 minutes; added garbage collection window of 10 minutes; disabled refetching on window focus.
Deployment Headers
vercel.json
Added cache-control headers for Pretendard font files with 1-year max-age and immutable flag for both admin and user app paths.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested reviewers

  • oriNuguri25
  • dgKim1

Poem

🐰 Fonts loaded swift, v1 now in place,
Cache headers guard the fontwear race,
Orders memoized, keeping rerenders at bay,
Five minutes of freshness, the API way!

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc085b8 and 6407f77.

⛔ Files ignored due to path filters (2)
  • apps/nowait-admin/public/fonts/pretendard/PretendardVariable.woff2 is excluded by !**/*.woff2
  • apps/nowait-user/public/fonts/pretendard/PretendardVariable.woff2 is excluded by !**/*.woff2
📒 Files selected for processing (11)
  • apps/nowait-admin/index.html
  • apps/nowait-admin/public/fonts/pretendard/pretendardvariable.css
  • apps/nowait-admin/src/pages/AdminOrders/AdminOrders.tsx
  • apps/nowait-user/index.html
  • apps/nowait-user/public/fonts/pretendard/pretendardvariable.css
  • apps/nowait-user/src/api/menu.ts
  • apps/nowait-user/src/api/order.ts
  • apps/nowait-user/src/api/reservation.ts
  • apps/nowait-user/src/pages/waiting/boothMap/hooks/useBooths.ts
  • packages/tailwind-config/shared-styles.css
  • vercel.json

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants