Skip to content

feat: MapManage 페이지 Map ref 변경#579

Merged
hwangdae merged 2 commits intomainfrom
develop
Jan 31, 2026
Merged

feat: MapManage 페이지 Map ref 변경#579
hwangdae merged 2 commits intomainfrom
develop

Conversation

@hwangdae
Copy link
Collaborator

@hwangdae hwangdae commented Jan 31, 2026

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • UI Improvements

    • Map container now displays at full viewport height for better visibility and usability.
  • Updates

    • Booth position coordinates have been updated for improved location accuracy.

✏️ Tip: You can customize this high-level summary in your review settings.

@hwangdae hwangdae merged commit b3ea652 into main Jan 31, 2026
2 of 3 checks passed
@github-actions github-actions bot requested a review from dgKim1 January 31, 2026 20:56
@coderabbitai
Copy link

coderabbitai bot commented Jan 31, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

The PR refactors map instance management in MapManagePage from a custom hook to local React state, updates MapCanvas to accept and propagate a setMap callback to the NaverMap component, reformats marker manager logic with dependency array adjustments, modifies map container height to viewport-relative sizing, and updates booth position coordinates.

Changes

Cohort / File(s) Summary
Map Instance Management
apps/nowait-user/src/pages/waiting/BoothMapManage/MapManagePage.tsx, apps/nowait-user/src/pages/waiting/BoothMapManage/components/MapCanvas.tsx
Replaces useMap hook with local useState, passes setMap callback to MapCanvas which now forwards it as ref to NaverMap component for map instance access from parent.
Marker Manager
apps/nowait-user/src/pages/waiting/BoothMapManage/hooks/useMarkerManager.ts
Reformats type annotations and expressions to single-line format, collapses existence check logic, adds isActive dependency to addMarker useCallback dependency array.
Map Display Styling
apps/nowait-user/src/pages/waiting/boothMap/MapPage.tsx
Updates map container height from fixed 600px to full viewport height (100vh).
Booth Coordinates
apps/nowait-user/src/pages/waiting/boothMap/constants/boothPosition.ts
Replaces BOOTHPOSITION entries: removes keys 16, 37, 39, 1, 2, 3, 4, 24 and adds/updates keys 29, 2, 3, 4, 5 with new latitude/longitude values.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • Develop #529: Modifies the same MapCanvas and MapManagePage components with setMap prop changes and map state management refactoring.
  • 맵 페이지 코드 정리 #575: Directly refactors map instance propagation from useMap hook to explicit state and prop passing in MapManagePage and MapCanvas.
  • merge to main #369: Updates booth position coordinates in boothPosition.ts and modifies related map display components (MapPage, MapManagePage).

Suggested reviewers

  • dgKim1
  • oriNuguri25

Poem

🐰 A map takes shape with state so pure,
No hooks to chase, the flow's secure,
Booths repositioned, canvas aligned,
The viewport stretches, references bind,
A rabbit's maze now maps the way! 🗺️

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant