Feat: Use Fabric's 3.1 batch writes for transactions #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit implements batch writes in the `flushWrites` method of `GalaChainStub`. This is done by using the `startWriteBatch` and `finishWriteBatch` methods from the underlying `fabric-shim` library. The following changes were made: - Added `startWriteBatch` and `finishWriteBatch` to the `GalaChainStub` interface. - Implemented `startWriteBatch` and `finishWriteBatch` in the `StubCache` class. - Modified the `flushWrites` method in `StubCache` to use the new batching methods. - Updated the test fixtures to include the new methods.
dzikowski-ai
changed the title
dzikowski-ai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit implements batch writes in the
flushWritesmethod ofGalaChainStub. This is done by using thestartWriteBatchandfinishWriteBatchmethods from the underlyingfabric-shimlibrary.The following changes were made:
startWriteBatchandfinishWriteBatchto theGalaChainStubinterface.startWriteBatchandfinishWriteBatchin theStubCacheclass.flushWritesmethod inStubCacheto use the new batching methods.closes #645