Feat: Replace elliptic with secp256k1-node to improve performance
#697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
…llisions - Introduced setCurrentTime method to manage transaction timestamps more effectively. - Ensured timestamps are at least 100 ms in the past to prevent silent test failures. - Updated GalaChainContext to use a constant for nanos per millisecond for clarity. Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
dzikowski
commented
Oct 30, 2025
Comment on lines
+173
to
+180
| // We observed that with higly optimized testing code with a very short | ||
| // latency, test process may fail silently with no stack trace because | ||
| // of (1) a timestamp collision, or (2) a timestamp that equals or exceeds | ||
| // the current time. | ||
| // | ||
| // To avoid this, we first force the timestamp to be at least 100 ms | ||
| // in the past, and then in case of a timestamp collision, we increment | ||
| // the timestamp by 1 millisecond. |
Collaborator
Author
There was a problem hiding this comment.
this is an additional thing that turned out to be required for testing updated contracts. The performance boost was significant enough to make the timestamp issue to occur.
dzikowski
changed the title
secp256k1-nodesecp256k1-node to improve performance
Signed-off-by: Jakub Dzikowski <jakub.t.dzikowski@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.