Skip to content

Conversation

@ChrisJChang
Copy link
Collaborator

I accidentally introduced this in my recent heputils bug fixes. This was causing the Mac CIs to fail because they were getting confused about an overload.

@agbuckley , this will require updating on the main heputils repo as well. Happy to make another PR if you would like.

I accidentally introduced this in my recent heputils bug fixes
@ChrisJChang ChrisJChang self-assigned this Dec 8, 2023
@ChrisJChang
Copy link
Collaborator Author

The CI jobs will not fully succeed due to some other CI issues that we are in the process of solving ( the Mac CI jobs fail because of issues with rivet/contur.), but they can build gambit, which is further than the master branch gets.

@agbuckley
Copy link
Collaborator

I accidentally introduced this in my recent heputils bug fixes. This was causing the Mac CIs to fail because they were getting confused about an overload.

@agbuckley , this will require updating on the main heputils repo as well. Happy to make another PR if you would like.

Thanks @ChrisJChang ! I've directly applied this and the _cseqs copying in HepUtils upstream, and made a 1.4.2 release tag. No extra PRs needed :-)

@ChrisJChang
Copy link
Collaborator Author

Thanks Andy :)

@anderkve
Copy link
Collaborator

Looks like the Ubuntu CI job is just failing due to this known issue: #463

@anderkve
Copy link
Collaborator

anderkve commented Dec 13, 2023

Since this is a tiny fix and the CI jobs are just failing due to issues we are working on elsewhere, I'll merge this to master now. Then we can get it into e.g. #462 and make further progress there.

@anderkve anderkve merged commit 11d8230 into master Dec 13, 2023
@anderkve anderkve deleted the heputils_cifix branch December 13, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants