Crossbow Cartridges - Fix torch place fail playing placement sound #1231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
requested changes
Jan 4, 2026
|
|
||
| # summon torch item if torch already exists at this block | ||
| execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch | ||
| execute if block ~ ~ ~ #gm4_crossbow_cartridges:torch store success score $dropped_item gm4_cb_misc run loot spawn ~ ~ ~ loot minecraft:blocks/copper_torch |
Member
There was a problem hiding this comment.
Do we even need this first check? The next "#gm4:replaceable" should also fail if the current block is a torch. The execute store can be moved just before calling the place function, and then the "summon torch" and "item drop" can check this score with opposite values.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1187