Allow for serializing pretty printed messages back to its FIX raw format #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This settings is not required anymore. Remove deprecated settings on .npmrc causing warning: ``` npm warn Unknown project config "scripts-prepend-node-path". This will stop working in the next major version of npm. ```
Add possibility to serialize pretty printed FIX messages back to its raw FIX format. It does it by adding functions to parse already pretty printed messages and to serialize parsed Messages to FIX format. for more details, look at the doc/RAW_FIX_CONVERTER.md file
Fix eslint configuration and add rules to mimic earlier configuration.
davidmpaz
force-pushed
the
main
branch
2 times, most recently
from
72dd340 to
ec32157
Compare
Run tests on the workflow file
Owner
|
Thanks @davidmpaz! I really appreciate all the work you've done here. Let me do some review and testing and then I'm sure I can merge and push a new release out. |
Parse pretty printed messages while normalizing line endings to it is agnostic to whatever OS is the user using. Not using VSCode api for determining the line ending since the function uses a string as parameter and there is not Window or Document object involved in current functionality. Just good old search and replace to assume consistent line endings.
Contributor
Author
|
Hi @GaryHughes, your welcome! I am happy to help, and since I do believe in open source, that's why I give back, whenever I can. Feel free to change/remove anything you see fit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
thanks for writing this extension! It really helps when you are working with FIX protocols.
Recently we kind of felt the need to have exactly what is asked for in #30. Could you please review this pull request and see if it is a good fit to solve that issue? I would love to have this included on the mainstream.
Updates:
scripts-prepend-node-pathfrom.npmrc since it is not needed anymore and deprecatedThanks advance and regards,
David