Merged
Conversation
teald
added
maintenance
This un-deprecates add_header_to_table as it is now used in DRAGONS. The need for this function was brought up during the pyOpenSci review, and looking back at that it seems like the concerns there are still addressed (now that there's a docstring, and it's not used elsewhere in astrodata).
teald
force-pushed
the
fix/undeprecate_add_header_to_table
branch
from
8fd3059 to
3691937
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This un-deprecates
add_header_to_tableas it is now used in DRAGONS. The need for this function was brought up during the pyOpenSci review, and looking back at that it seems like the concerns there are still addressed (now that there's a docstring, and it's not used elsewhere in astrodata).