fix false-> true

[audreyyeoCH]

closes #146

[github-actions]

Code Coverage Summary

Filename                 Stmts    Miss  Cover    Missing
---------------------  -------  ------  -------  -----------
R/betadiff.R                78       0  100.00%
R/boundsPostprob.R          44       0  100.00%
R/boundsPredprob.R          56       1  98.21%   83
R/dbetabinom.R              99       3  96.97%   32, 62, 154
R/oc2.R                    162     162  0.00%    93-326
R/oc3.R                    146     146  0.00%    91-308
R/ocPostprob.R             117       0  100.00%
R/ocPostprobDist.R         122       0  100.00%
R/ocPredprob.R             205       0  100.00%
R/ocPredprobDist.R         257       5  98.05%   363-367
R/ocRctPostprobDist.R      174       0  100.00%
R/ocRctPredprobDist.R      302       0  100.00%
R/plotBeta.R                97       9  90.72%   124-132
R/plotBounds.R              83      83  0.00%    42-130
R/plotDecision.R            73       0  100.00%
R/plotOc.R                  55       2  96.36%   99-100
R/postprob.R                34       1  97.06%   113
R/postprobDist.R            77       1  98.70%   204
R/predprob.R                36       0  100.00%
R/predprobDist.R           140       1  99.29%   269
R/runShinyPhase1b.R          4       4  0.00%    8-13
R/sumBetaDiff.R             80      15  81.25%   102-120
R/sumTable.R                36       0  100.00%
TOTAL                     2477     433  82.52%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 3d83aec

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[danielinteractive]

As usual when there is a bug fix can you please add a test that first reproduces the bug and then is fixed with this change?

[github-actions]

Unit Tests Summary

    1 files     20 suites   9m 44s ⏱️
  141 tests   138 ✅ 0 💤 2 ❌ 1 🔥
2 581 runs  2 577 ✅ 0 💤 3 ❌ 1 🔥

For more details on these failures and errors, see this check.

Results for commit f25bf7a.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
ocPredprob	💚	$210.46$	$-7.84$	$+9$	$0$	$0$	$0$
ocPredprobDist	💚	$96.94$	$-3.24$	$0$	$0$	$0$	$0$
plotOc	💚	$214.92$	$-5.41$	$0$	$0$	$0$	$0$
predprobDist	💚	$26.26$	$-10.82$	$-1192$	$0$	$0$	$+1$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
ocPredprob	👶		$+0.43$	Go_decision_for_all_interims_when_criteria_met_for_decision_1
ocPredprob	💚	$207.62$	$-8.24$	ocPredprob_correctly_shows_maximum_sample_size_when_no_decision_reached
ocPredprobDist	💚	$62.42$	$-2.18$	ocPredprobDist_gives_higher_PrFutility_with_more_futility_looks
plotOc	💚	$57.16$	$-1.45$	h_get_dataframe_oc_gives_correct_results_for_ocPredprobDist_when_relativeDelta_FALSE
plotOc	💚	$105.52$	$-2.87$	plotOc_gives_expected_results_for_ocPredprobDist_with_different_relativeDelta_status
predprobDist	💚	$2.29$	$-2.06$	h_predprobdist_gives_correct_list
predprobDist	💔	$6.59$	$+2.30$	h_predprobdist_gives_higher_predictive_probability_when_thetaT_is_lower
predprobDist	💚	$11.91$	$-11.89$	predprobDist_gives_higher_predictive_probability_when_thetaT_is_lower_in_a_single_arm_trial

Results for commit 2879ab0

♻️ This comment has been updated with latest results.

[danielinteractive]

Thanks @audreyyeoCH !

[danielinteractive]

Good to go from my side already before, but you first have to fix the check errors

[audreyyeoCH]

Good to go from my side already before, but you first have to fix the check errors

thanks @danielinteractive, did you see the comment from above ? I wasn't able to get a link