get hotel id feature ticket #62
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danctila
requested changes
Jan 17, 2026
Contributor
danctila
left a comment
danctila
left a comment
There was a problem hiding this comment.
overall great stuff @tars919 🎉. couple of notes and a few minor changes requested mostly to naming.
good:
- error handling (400, 404, 500) 🙏
- UUID validation is correct, test coverage is epic
- existing repo patterns
changes requested:
- naming conventions (GetById -> FindByID in repository)
- move
HotelRepositoryinterface fromstorage.gotorepo_types.go - Swagger godoc comments to handler method
backend/internal/handler/hotels.go
Outdated
|
|
||
| //Interface for hotel repository -> used in testing later | ||
| type HotelRepository interface { | ||
| GetByID(ctx context.Context, id string) (*models.Hotel, error) |
Contributor
There was a problem hiding this comment.
Should be FindByID per naming convention (repository methods for GET should use find prefix). Applies to both the interface and implementation
| return &HotelRepository{db: db} | ||
| } | ||
|
|
||
| func (r *HotelRepository) GetByID(ctx context.Context, id string) (*models.Hotel, error) { |
Contributor
There was a problem hiding this comment.
Method should be FindByID per naming convention
| DB: db, | ||
| DevsRepository: repository.NewDevsRepository(db), | ||
| RequestRepository: repository.NewRequestsRepo(db), | ||
| //added for hotel |
Comment on lines
18
to
20
| type HotelRepository interface { | ||
| GetByID(ctx context.Context, id string) (*models.Hotel, error) | ||
| } |
Contributor
There was a problem hiding this comment.
Suggested change
| type HotelRepository interface { | |
| GetByID(ctx context.Context, id string) (*models.Hotel, error) | |
| } | |
| type HotelRepository interface { | |
| FindByID(ctx context.Context, id string) (*models.Hotel, error) | |
| } |
backend/internal/service/server.go
Outdated
| helloHandler := handler.NewHelloHandler() | ||
| devsHandler := handler.NewDevsHandler(repository.NewDevsRepository(repo.DB)) | ||
| reqsHandler := handler.NewRequestsHandler(repository.NewRequestsRepo(repo.DB)) | ||
| hotelHandler := handler.NewHotelHandler(repository.NewHotelRepository(repo.DB)) //for hotel |
backend/internal/service/server.go
Outdated
| r.Post("/", reqsHandler.CreateRequest) | ||
| }) | ||
|
|
||
| // hotel routes |
- changed naming conventions - added swagger comments - moved interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is documenting the implementation for the get hotels id ticket to retrieve a single hotel by its given UUID.
Type of Change
Related Issue(s)
Closes #43
What Changed?
Testing & Validation
How to Test
Test Coverage
Screenshots/Recordings
Unfinished Work & Known Issues
Notes & Nuances
Deployment Considerations
backend/supabase/migrations/).env.example)Pre-Merge Checklist
Code Quality
Testing & CI
Documentation
Security & Performance
Reviewer Notes
Areas needing extra attention:
Questions for reviewers: ...
Concerns: ...